[fix] View environment customizations on hosting VCs now propagate to SwiftUI environment #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmaceachern
force-pushed
the
robmaceachern/hosting-controller-env-obs
branch
from
1291827 to
38e6320
Compare
robmaceachern
commented
Aug 22, 2024
| import ViewEnvironment | ||
| @_spi(ViewEnvironmentWiring) import ViewEnvironmentUI | ||
| import XCTest | ||
| @testable import WorkflowSwiftUI |
There was a problem hiding this comment.
@watt The @testable was required here because the StateAccessor init is not public. Not sure if that was intentional or not. I can open it up as part of this if you'd like!
There was a problem hiding this comment.
hmm, probably OK if it's public.
mjohnson12
approved these changes
Aug 22, 2024
watt
approved these changes
Aug 22, 2024
| import ViewEnvironment | ||
| @_spi(ViewEnvironmentWiring) import ViewEnvironmentUI | ||
| import XCTest | ||
| @testable import WorkflowSwiftUI |
There was a problem hiding this comment.
hmm, probably OK if it's public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensure that any view environment customizations made to a Swift UI screen's backing VC are propagated to the SwiftUI environment. We hit this issue in Market when attempting to propagate the VC's navigation item to SwiftUI and there may be other uses for this behaviour too.
Checklist